[PATCH v5 1/3] color.c: fix color_parse_mem() with value_len == 0

From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date: Jan 19, 2017, 11:41 UTC
Message-ID: <20170119114123.23784-2-pclouds@gmail.com>
In-Reply-To: <20170119114123.23784-1-pclouds@gmail.com>

In this code we want to match the word "reset". If len is zero, strncasecmp() will return zero and we incorrectly assume it's "reset" as a result.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 color.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/color.c b/color.c
index 81c2676..a9eadd1 100644
--- a/color.c
+++ b/color.c
@@ -207,6 +207,9 @@ int color_parse_mem(const char *value, int value_len, char *dst)
 	struct color fg = { COLOR_UNSPECIFIED };
 	struct color bg = { COLOR_UNSPECIFIED };
 
+	if (!len)
+		return -1;
+
 	if (!strncasecmp(value, "reset", len)) {
 		xsnprintf(dst, end - dst, GIT_COLOR_RESET);
 		return 0;

-- 
2.8.2.524.g6ff3d78