git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 22, 2017, 06:28 UTC
Message-ID
<xmqqfu96u8s4.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171122051014.GA7625@aiede.mtv.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 13 quoted lines
>>> This comment doesn't tell me how to use the function.  How do I detect
>>> whether it successfully read a line?  What do the return values
>>> represent?  What happens if the line it read doesn't match the key?
>>
>> Would this work for both of you?
>>
>> # Read a text packet, expecting that it is in the form "key=value" for
>> # the given $key.  An EOF does not trigger any error and is reported
>> # back to the caller (like packet_txt_read() does).  Die if the "key"
>> # part of "key=value" does not match the given $key, or the value part
>> # is empty.
>
> Yes, thank you.

Heh. I actually was expecting a different response: "that describes what the reader can easily read out of the implementation and is useless", though.

Previous: Jonathan NiederNext: Jonathan Nieder
Message 8 of 11 in “Git/Packet.pm: rename packet_required_key_val_read()”
  1. 1/2 Git/Packet.pm: rename packet_required_key_val_read()Christian Couder, Nov 21, 2017
  2. 2/2 Git/Packet.pm: use 'if' instead of 'unless'Christian Couder, Nov 21, 2017
  3. Jonathan NiederNov 21, 2017
  4. Junio C HamanoNov 22, 2017
  5. Jonathan NiederNov 21, 2017
  6. Junio C HamanoNov 22, 2017
  7. Jonathan NiederNov 22, 2017
  8. Junio C HamanoNov 22, 2017
  9. Jonathan NiederNov 22, 2017
  10. Christian CouderNov 22, 2017
  11. Junio C HamanoNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.