git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 12, 2017, 19:57 UTC
Message-ID
<xmqqfu8f1zyv.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<xmqqk1xr204t.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> Makes sense.  The patch looks scary by appearing to move the
> includes far to the front of the Makefile, but it in fact is moving
> the NO_DC_SHA1_SUBMODULE block slightly down and it is a sensible
> and safe move.

A completely unrelated tangent. This was a good change to try your anchored diff on. Viewing this change with

   $ git show --anchored='include config.mak'

looks a lot less scary than the way it is shown by default (which matches what was posted on the list).

Good job.
Previous: Junio C HamanoNext: Jonathan Tan
Message 3 of 8 in “Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak”
  1. Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.makRamsay Jones, Dec 12, 2017
  2. Junio C HamanoDec 12, 2017
  3. Junio C HamanoDec 12, 2017
  4. Jonathan TanDec 12, 2017
  5. Ævar Arnfjörð BjarmasonDec 12, 2017
  6. Junio C HamanoDec 12, 2017
  7. Junio C HamanoDec 12, 2017
  8. Ævar Arnfjörð BjarmasonDec 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.