Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Dec 12, 2017, 21:11 UTC
- Message-ID
- <20171212131158.ec87dcde2a74dd879068cd95@google.com>
- In-Reply-To
- <xmqqfu8f1zyv.fsf@gitster.mtv.corp.google.com>
On Tue, 12 Dec 2017 11:57:28 -0800 Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > Makes sense. The patch looks scary by appearing to move the > > includes far to the front of the Makefile, but it in fact is moving > > the NO_DC_SHA1_SUBMODULE block slightly down and it is a sensible > > and safe move. > > A completely unrelated tangent. This was a good change to try your > anchored diff on. Viewing this change with > > $ git show --anchored='include config.mak' > > looks a lot less scary than the way it is shown by default (which > matches what was posted on the list). > > Good job.
Thanks, glad that it helped.