Re: [PATCH v2 11/17] fetch tests: fetch <url> <spec> as well as fetch [<remote>]
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2018, 20:57 UTC
- Message-ID
- <xmqqfu69x4mr.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <87zi4ikjyr.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 10 quoted lines
>>> + key=$(echo $1 | sed -e 's/^remote\.origin/fetch/')
>>
>> Faster (thus more Windows-friendly) assuming that $1 always starts
>> with "remote.origin":
>>
>> key=fetch${u#remote.origin}
>
> Tests fail with this and I'm not excited to be the first user in git's
> test suite to use some novel shell feature, no existing uses of
> ${u[...].s/u/1/, I think.