[PATCH v5 01/17] fetch: don't redundantly NULL something calloc() gave us

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Feb 9, 2018, 20:32 UTC
Message-ID: <20180209203216.11560-2-avarab@gmail.com>
In-Reply-To: <20180209203216.11560-1-avarab@gmail.com>

Stop redundantly NULL-ing the last element of the refs structure, which was retrieved via calloc(), and is thus guaranteed to be pre-NULL'd.

This code dates back to b888d61c83 ("Make fetch a builtin", 2007-09-10), where wasn't any reason to do this back then either, it's just boilerplate left over from when git-fetch was initially introduced.

The motivation for this change was to make a subsequent change which would also modify the refs variable smaller, since it won't have to copy this redundant "NULL the last + 1 item" pattern.

We may not end up keeping that change, but as this pattern is still pointless, so let's fix it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/fetch.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 7bbcd26faf..b34665db9e 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1302,7 +1302,6 @@ static int fetch_one(struct remote *remote, int argc, const char **argv)
 			} else
 				refs[j++] = argv[i];
 		}
-		refs[j] = NULL;
 		ref_nr = j;
 	}

-- 
2.15.1.424.g9478a66081