Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2018, 20:12 UTC
Message-ID: <xmqqfu5v2zfj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180220193834.GM27038@zaya.teonanacatl.net>

Todd Zullinger <tmz@pobox.com> writes:

Show 15 quoted lines

> If replacing the non-ASCI apostrophes is the goal, aren't
> there a number of others in the same file worth cleaning up
> at the same time?
>
> $ grep '’' Documentation/gitsubmodules.txt
> the submodule’s working directory pointing to (i).
> superproject expects the submodule’s working directory to be at.
> When deinitialized or deleted (see below), the submodule’s Git
> but no submodule working directory. The submodule’s Git directory
> the superproject’s `$GIT_DIR/config` file, so the superproject’s history
> The deletion removes the superproject’s tracking data, which are
> The submodule’s working directory is removed from the file
>
> This does seem to be the only file which includes the
> non-ASCII apostrophe under Documentation.

Thanks for checking. I agree that it is a good idea to clean the whole file up at the same time. The title would need to be updated, as it will no longer be "fix misconversion". The justification would also become different---"the 'overhaul' did not just move the text but made the apostrophe style changes and reverting that change is a good thing" was a good justification for "fix misconversion", but now we need to explain to the future readers of "git log" why we prefer to turn all of them in this file to ASCII single quotes (just saying "make it consistent" is sufficient).

Thanks.