git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

From
Stefan Beller <sbeller@google.com>
Date
Feb 20, 2018, 18:50 UTC
Message-ID
<CAGZ79kajrwqu2X7BRe8w0W_sa0nosXxspfhbrm0d-ASzxCLn-A@mail.gmail.com>
In-Reply-To
<01020161b30b99df-5029ec2b-a5cb-475b-b54f-9879a117a7f3-000000@eu-west-1.amazonses.com>

Kaartic was the last to touch that file, (as found via git log origin/master -- Documentation/gitsubmodules.txt), sorry I did not find this in the review.

Thanks for the patch! Stefan

On Tue, Feb 20, 2018 at 3:48 AM, marmot1123 <marmot.motoki@gmail.com> wrote:
Show 33 quoted lines
> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.
> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.
>
> Signed-off-by: Motoki Seki <marmot.motoki@gmail.com>
> ---
>  Documentation/gitsubmodules.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
> index 46cf120f666df..0d59ab4cdfb1c 100644
> --- a/Documentation/gitsubmodules.txt
> +++ b/Documentation/gitsubmodules.txt
> @@ -24,7 +24,7 @@ On the filesystem, a submodule usually (but not always - see FORMS below)
>  consists of (i) a Git directory located under the `$GIT_DIR/modules/`
>  directory of its superproject, (ii) a working directory inside the
>  superproject's working directory, and a `.git` file at the root of
> -the submodule’s working directory pointing to (i).
> +the submodule's working directory pointing to (i).
>
>  Assuming the submodule has a Git directory at `$GIT_DIR/modules/foo/`
>  and a working directory at `path/to/bar/`, the superproject tracks the
> @@ -33,7 +33,7 @@ in its `.gitmodules` file (see linkgit:gitmodules[5]) of the form
>  `submodule.foo.path = path/to/bar`.
>
>  The `gitlink` entry contains the object name of the commit that the
> -superproject expects the submodule’s working directory to be at.
> +superproject expects the submodule's working directory to be at.
>
>  The section `submodule.foo.*` in the `.gitmodules` file gives additional
>  hints to Gits porcelain layer such as where to obtain the submodule via
>
> --
> https://github.com/git/git/pull/459
Previous: marmot1123Next: Kaartic Sivaraam
Message 5 of 9 in “Fix misconversion of gitsubmodule.txt”
  1. Fix misconversion of gitsubmodule.txtmarmot1123, Feb 20, 2018
  2. Eric SunshineFeb 20, 2018
  3. brian m. carlsonFeb 20, 2018
  4. Fix misconversion of gitsubmodule.txtmarmot1123, Feb 20, 2018
  5. Stefan BellerFeb 20, 2018
  6. Kaartic SivaraamFeb 20, 2018
  7. Stefan BellerFeb 20, 2018
  8. Todd ZullingerFeb 20, 2018
  9. Junio C HamanoFeb 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.