Re: [PATCH] doc: fix config API documentation about config_with_options

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2018, 01:00 UTC
Message-ID: <xmqqfu2xg02z.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180509171950.GB63423@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 20 quoted lines

> On 05/09, Antonio Ospite wrote:
>> In commit dc8441fdb ("config: don't implicitly use gitdir or commondir",
>> 2017-06-14) the function git_config_with_options was renamed to
>> config_with_options to better reflect the fact that it does not access
>> the git global config or the repo config by default.
>> 
>> However Documentation/technical/api-config.txt still refers to the
>> previous name, fix that.
>> 
>> While at it also update the documentation about the extra parameters,
>> because they too changed since the initial definition.
>> 
>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>> ---
>> 
>> Patch based on the maint branch.
>
> Thanks for updating the docs.  Maybe one day we can migrate these docs
> to the source files themselves, making it easier to keep up to date.
> For now this is good :)

Thanks, both.