Re: [PATCH] doc: fix config API documentation about config_with_options

From: Antonio Ospite <ao2@ao2.it>
Date: May 11, 2018, 22:17 UTC
Message-ID: <20180512001705.1ce66754ce72d2b57c7e6d96@ao2.it>
In-Reply-To: <20180509171950.GB63423@google.com>

On Wed, 9 May 2018 10:19:50 -0700 Brandon Williams <bmwill@google.com> wrote:

Show 21 quoted lines

> On 05/09, Antonio Ospite wrote:
> > In commit dc8441fdb ("config: don't implicitly use gitdir or commondir",
> > 2017-06-14) the function git_config_with_options was renamed to
> > config_with_options to better reflect the fact that it does not access
> > the git global config or the repo config by default.
> > 
> > However Documentation/technical/api-config.txt still refers to the
> > previous name, fix that.
> > 
> > While at it also update the documentation about the extra parameters,
> > because they too changed since the initial definition.
> > 
> > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> > ---
> > 
> > Patch based on the maint branch.
> 
> Thanks for updating the docs.  Maybe one day we can migrate these docs
> to the source files themselves, making it easier to keep up to date.
> For now this is good :)
>

Should I resend the patch to gitster@pobox.com with your Acked-by?

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?