Re: [RFC PATCH 3/5] pack-objects: add delta-islands support
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2018, 17:11 UTC
- Message-ID
- <xmqqfu08zhh7.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqqk1pkzhuo.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
>> +------------------------------------------- >> +[pack] >> +island = refs/virtual/([0-9]+)/heads/ >> +island = refs/virtual/([0-9]+)/tags/ >> +island = refs/virtual/([0-9]+)/(pull)/ >> +------------------------------------------- > > It becomes clear only from this example that what the feature calls > (and documented in patch 2/5) "regexp" is not BRE but ERE. Update > 2/5 so that it is clear to readers of "git config --help" who looks > for "pack.island" in the output. > >> +That puts the heads and tags for each fork in their own island (named >> +"1234" or similar), and the pull refs for each go into their own >> +"1234-pull". > > "by concatenating any capture groups" made me imagine that the last > one would be "1234pull" without dash. The actual rule should be > mentioned in that paragraph (i.e. "concatenating any capture groups > from the regex, with a '-' dash in between" or something like that).
Another thing I noticed from 2/5 is that you can have up to 7 such capture groups. I do not have any opinion if 7 is too few or too many, but we would want the number to be documented, and end-user input diagnosed when it requires more captures than we support (if we are not already checking, that is).