Re: [PATCH 1/1] t/test-lib: make `test_dir_is_empty` more robust
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 5, 2018, 06:03 UTC
- Message-ID
- <xmqqftzts63d.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180805041956.GI258270@aiede.svl.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> but $'' is too recent of a shell feature to count on (e.g., dash doesn't > support it). See t/t3600-rm.sh for an example of a portable way to do
Is that "too recent"? I thought it was bashism, not even in POSIX, but I may be mistaken.
Quite honestly, our tests are still run inside a sort-of controlled environment, so if it _requires_ use of things we have avoided so far, like "ls -A" and "xargs -0", in order to be resistant to funnyly-named files like dot-LF-dot, I would say it is not worth worrying about them--instead we can simply refrain from using such a pathological name, can't we?
"ls -A" may be in POSIX, but our attitude generally is to avoid saying things like "it is in POSIX so it's your platform's fault that it is not yet supported". We instead say "even it may be in POSIX, in real life many people don't have it, so let's avoid it". And "xargs -0" I do not think is.