Re: [PATCH 1/1] t/test-lib: make `test_dir_is_empty` more robust
- From
Jeff King <peff@peff.net>
- Date
- Aug 6, 2018, 13:02 UTC
- Message-ID
- <20180806130216.GA29966@sigill.intra.peff.net>
- In-Reply-To
- <20180805205231.GA14688@sigill.intra.peff.net>
On Sun, Aug 05, 2018 at 04:52:31PM -0400, Jeff King wrote:
Show 18 quoted lines
> On Sun, Aug 05, 2018 at 01:23:05AM -0400, Eric Sunshine wrote:
>
> > A simpler approach, without the portability concerns of -A, would be
> > to remove the "." and ".." lines from the top of the listing:
> >
> > ls -f1 "$1" | sed '1,2d'
> >
> > If we're worried about -f not being sufficiently portable, then an
> > even simpler approach would be to check whether the output of 'ls -a1'
> > has more lines than the two expected ("." and ".."):
> >
> > test $(ls -a1 "$1" | wc -l) -gt 2
> >
> > I think I favor this final implementation over the others.
>
> Perhaps even simpler:
>
> test "$1" = "$(find "$1")"Actually, I guess it needs to add "-print", since IIRC that is not the default on some old versions of "find".
-Peff