git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2018, 06:01 UTC
Message-ID
<xmqqftwmwt7b.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181030121630.0aec137f670bd5d3486cccc5@ao2.it>
Antonio Ospite <ao2@ao2.it> writes:
Show 10 quoted lines
> I see, this is also mentioned in t/README, I had overlooked that part.
> Thank you for reporting.
>
>> Without this fix, your new test case will fail on Windows all the time,
>> see e.g.
>> https://git-for-windows.visualstudio.com/git/_build/results?buildId=22913&view=logs
>> 
>
> Junio, what is the plan for 'ao/submodule-wo-gitmodules-checked-out'?
>
I did not and do not have a specific plan ;-)

If the only remaining issue in the previous round of the topic were what you said in <20181010205645.e1529eff9099805029b1d6ef@ao2.it>, which you addressed in this round, and given that Stefan (who is likely to be the person who would need to work with you if there is any issues later found in this topic) seemed to be happy with it in <CAGZ79katS+PHWWD_0EqSmoEFazE0vAbMsg8G+iowNfbDmMkyMg@mail.gmail.com>, I'd say with Dscho's bug fixed, it should be ready for 'next'.

> I see it's not in next yet; do you want me to resend the whole series
> with this fixup in or would it be less overhead for you to apply it
> directly to patch 9/10 from v7 of the series?

In either way, this involves rebuilding ao/* topic and then redoing sb/submodule-recursive-fetch-gets-the-tip topic on top, before I can do the 'pu' with them, so I cannot promise it will happen today, but let's see. I think I have enough material to do the fix-up locally without any additional thing sent from you.

Thanks.
> P.S. I was wondering if it is worth having patchset versions mentioned
> somewhere in pu/, maybe in merge commits if not in branch names?
No, not in branch names.

The tip date published in the "What's cooking" report is taken from the committer date but we may want to use the author date instead, which may help (and encourage people to be careful _before_ sending things out, to avoid doing many rerolls in a day).

Previous: Antonio OspiteNext: Antonio Ospite
Message 8 of 17 in “Make submodules work if .gitmodules is not checked out”
  1. 00/10 Make submodules work if .gitmodules is not checked outAntonio Ospite, Oct 25, 2018
  2. 01/10 submodule: add a print_config_from_gitmodules() helperAntonio Ospite, Oct 25, 2018
  3. 05/10 submodule--helper: add a new 'config' subcommandAntonio Ospite, Oct 25, 2018
  4. 04/10 t7411: be nicer to future tests and really clean things upAntonio Ospite, Oct 25, 2018
  5. 09/10 submodule: support reading .gitmodules when it's not in the working treeAntonio Ospite, Oct 25, 2018
  6. Johannes SchindelinOct 30, 2018
  7. Antonio OspiteOct 30, 2018
  8. Junio C HamanoOct 31, 2018
  9. 07/10 t7506: clean up .gitmodules properly before setting up new scenarioAntonio Ospite, Oct 25, 2018
  10. 06/10 submodule: use the 'submodule--helper config' commandAntonio Ospite, Oct 25, 2018
  11. 08/10 submodule: add a helper to check if it is safe to write to .gitmodulesAntonio Ospite, Oct 25, 2018
  12. 10/10 t/helper: add test-submodule-nested-repo-configAntonio Ospite, Oct 25, 2018
  13. 02/10 submodule: factor out a config_set_in_gitmodules_file_gently functionAntonio Ospite, Oct 25, 2018
  14. 03/10 t7411: merge tests 5 and 6Antonio Ospite, Oct 25, 2018
  15. Stefan BellerOct 25, 2018
  16. Junio C HamanoOct 26, 2018
  17. Stefan BellerOct 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.