git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 17, 2019, 21:18 UTC
Message-ID
<xmqqfttrm18w.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190117183727.260298-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 20 quoted lines
>> I'm happy to have you pick that up as you've done here, especially since
>> you're actually working on v2 and I'm not, so you can more easily know
>> what it conflicts with etc. I just wanted to have it in one way or
>> another, i.e. be able to deploy v2 and assert that "next + custom
>> patches" doesn't break something for v2.
>> 
>> I think [CC: Junio] that we shouldn't be concerned about an addition of
>> GIT_TEST_PROTOCOL_VERSION patches in any form breaking the test suite
>> under GIT_TEST_PROTOCOL_VERSION=2, and just be concerned about the
>> default GIT_TEST_PROTOCOL_VERSION= case. I.e. if we have v2 patches
>> in-flight that break things no big deal, we can always circle back and
>> fix those things or annotate the tests.
>
> That sounds good to me. My main concern is that this will end up being
> dead code (if we have too many tests that fail with
> GIT_TEST_PROTOCOL_VERSION=2 and no one bothers with it anymore), but I
> don't think that will happen - in this patch set, I have eliminated a
> lot of false failures and strove to give reasons for the
> GIT_TEST_PROTOCOL_VERSION= annotations, and I think there's interest
> (well, at least from me) in investigating the remaining apparent bugs.
Yup, sounds good to me, too.
Previous: Jonathan Tan
Message 12 of 12 in “[WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION”
  1. Jonathan TanJan 16, 2019
  2. 1/8 tests: define GIT_TEST_PROTOCOL_VERSIONJonathan Tan, Jan 16, 2019
  3. 2/8 tests: always test fetch of unreachable with v0Jonathan Tan, Jan 16, 2019
  4. 3/8 t5503: fix overspecification of trace expectationJonathan Tan, Jan 16, 2019
  5. 4/8 t5512: compensate for v0 only sending HEAD symrefsJonathan Tan, Jan 16, 2019
  6. 5/8 t5700: only run with protocol version 1Jonathan Tan, Jan 16, 2019
  7. 6/8 tests: fix protocol version for overspecificationsJonathan Tan, Jan 16, 2019
  8. 7/8 t5552: compensate for v2 filtering ref adv.Jonathan Tan, Jan 16, 2019
  9. 8/8 remote-curl: in v2, fill credentials if neededJonathan Tan, Jan 16, 2019
  10. Ævar Arnfjörð BjarmasonJan 17, 2019
  11. Jonathan TanJan 17, 2019
  12. Junio C HamanoJan 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.