git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[WIP 7/8] t5552: compensate for v2 filtering ref adv.

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jan 16, 2019, 22:42 UTC
Message-ID
<b5c7322c03d6c26aadd5242eafab880ceac4db9b.1547677183.git.jonathantanmy@google.com>
In-Reply-To
<cover.1547677183.git.jonathantanmy@google.com>

Protocol v2 filters the ref advertisement, but protocol v0 does not. A test in t5552 uses the ref advertisement, so fix it to use protocol v0.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 t/t5552-skipping-fetch-negotiator.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t5552-skipping-fetch-negotiator.sh b/t/t5552-skipping-fetch-negotiator.sh
index 30857b84a8..8a14be51a1 100755
--- a/t/t5552-skipping-fetch-negotiator.sh
+++ b/t/t5552-skipping-fetch-negotiator.sh
@@ -127,7 +127,10 @@ test_expect_success 'use ref advertisement to filter out commits' '
 	# not need to send any ancestors of "c3", but we still need to send "c3"
 	# itself.
 	test_config -C client fetch.negotiationalgorithm skipping &&
-	trace_fetch client origin to_fetch &&
+
+	# The ref advertisement itself is filtered when protocol v2 is used, so
+	# use v0.
+	GIT_TEST_PROTOCOL_VERSION= trace_fetch client origin to_fetch &&
 	have_sent c5 c4^ c2side &&
 	have_not_sent c4 c4^^ c4^^^
 '
-- 
2.19.0.271.gfe8321ec05.dirty
Previous: Jonathan TanNext: Jonathan Tan
Message 8 of 12 in “[WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION”
  1. Jonathan TanJan 16, 2019
  2. 1/8 tests: define GIT_TEST_PROTOCOL_VERSIONJonathan Tan, Jan 16, 2019
  3. 2/8 tests: always test fetch of unreachable with v0Jonathan Tan, Jan 16, 2019
  4. 3/8 t5503: fix overspecification of trace expectationJonathan Tan, Jan 16, 2019
  5. 4/8 t5512: compensate for v0 only sending HEAD symrefsJonathan Tan, Jan 16, 2019
  6. 5/8 t5700: only run with protocol version 1Jonathan Tan, Jan 16, 2019
  7. 6/8 tests: fix protocol version for overspecificationsJonathan Tan, Jan 16, 2019
  8. 7/8 t5552: compensate for v2 filtering ref adv.Jonathan Tan, Jan 16, 2019
  9. 8/8 remote-curl: in v2, fill credentials if neededJonathan Tan, Jan 16, 2019
  10. Ævar Arnfjörð BjarmasonJan 17, 2019
  11. Jonathan TanJan 17, 2019
  12. Junio C HamanoJan 17, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.