Re: [PATCH v2.5 2/2] tag: prevent nested tags

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2019, 09:31 UTC
Message-ID: <xmqqftqyf76a.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190404020226.GG4409@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I do still think it is likely to be a mistake. I think Junio's point,
> though is: who cares if the mistake was made? For the most part you can
> continue to use the tag as if the mistake had never been made, because
> Git peels through multiple layers as necessary.

Nicely said.

If we forget to peel, that is a bigger problem, but I do not think it makes any sense to single out tag-of-tag as "curious" and forbid it, when we silently allow tag-of-blob or tag-of-tree happily.

An opt-in (i.e. default to false) tag.allowTaggingOnlyCommits I do not have any problem with, and I could be persuaded into taking an opt-out (i.e. default to true) tag.forbidTaggingAnythingButCommits configuration, perhaps, though.