Re: [PATCH 0/3] tag: prevent recursive tags

From: Jeff King <peff@peff.net>
Date: Mar 26, 2019, 16:18 UTC
Message-ID: <20190326161818.GA29627@sigill.intra.peff.net>
In-Reply-To: <cover.1553586707.git.liu.denton@gmail.com>

On Tue, Mar 26, 2019 at 12:53:14AM -0700, Denton Liu wrote:

Show 5 quoted lines

> Peff said:
> > Yeah, that's probably a good idea. Now we just need somebody to write
> > the patch...
> 
> Hey would you look at that, somebody wrote the patch!

The system works. :)

Show 9 quoted lines

> Earlier in the mailing list[1], Robert Dailey reported confusion over
> some recursive tags.
> 
> Peff noted that he hasn't seen a tag-to-a-tag in the wild so in most
> cases, it'd probably be a mistake on the part of a user. He also
> suggested we error out on a recursive tag unless "--allow-recursive-tag"
> is provided.
> 
> This patchset implements those suggestions.

Thanks. I agree with all of the comments Ævar left, but other than that this looks pretty good to me.

The only hesitation I'd have is that turning this case into a hard error (rather than just an informative warning) may be too sudden for some people's tastes. I'm on the fence myself; I'll be curious what Junio thinks when he gets back.

-Peff