Re: [PATCH] git-gui: Perform rescan on window focus-in

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2019, 16:47 UTC
Message-ID: <xmqqftmjldjx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cc5dddc7-e33e-2a2c-3205-6dd14edd0abd@yadavpratyush.com>

Pratyush Yadav <me@yadavpratyush.com> writes:

> +Junio

I do not have a strong opinion on this one---a Meh by default means a moderately strong preference for status-quo.

Show 7 quoted lines

> All right, the patch in its current state can't fly. So what is the
> correct way to do this? I see the following options:
>
> 1. Add this as an option that is disabled by default, but people who
> don't mind it can enable it. This is the easiest to implement. But I
> leave it to you and Junio (and anyone else who wants to pitch in :))
> to decide if it is a good idea.

I think this is a good first step. As I said already, I am not convinced that "focus in" is a good heuristics for triggering auto rescan, and I suspect that you or others may come up with and replace it with a better heuristic over time. During that experiment, it would be better to allow interested others to opt into the feature to help, while not disturbing ordinary users who are OK with the current behaviour.