git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Perform rescan on window focus-in

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 31, 2019, 19:42 UTC
Message-ID
<nycvar.QRO.7.76.6.1907312132190.21907@tvgsbejvaqbjf.bet>
In-Reply-To
<005d7946-3fbf-9c06-21fb-51f10d06f33e@yadavpratyush.com>
Hi,
On Mon, 29 Jul 2019, Pratyush Yadav wrote:
Show 26 quoted lines
> On 29/07/19 7:58 AM, Mark Levedahl wrote:
> > On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at
> > 22:10:29, Pratyush Yadav wrote:
> > > > The function is not documented, and I only started spelunking
> > > > the code a couple days back, so I'll try to answer with what I
> > > > know. It might not be the full picture.
> > > >
> > > > Running git-gui --trace, these commands are executed during a rescan:
> > > >
> > > > /usr/lib/git-core/git-rev-parse --verify HEAD
> > > > /usr/lib/git-core/git-update-index -q --unmerged --ignore-missing --refresh
> > > >
> > >
> > > Great. This sounds like a well-reasoned change. I'll let other folks who
> > > use git-gui more chime in to see what they think as well.
> > >
> >
> > I'm assuming this does what is currently done by F5.
> > A simple rescan from git-gui in the git repository takes about 8 seconds on
> > my corporate laptop running Windows, making this happen on change of window
> > focus is definitely not a friendly change from my view point.
> >
>
> This is a Windows problem maybe? On my Linux machine with an almost dead hard
> drive, it takes under 10ms to do a refresh on the git repository (which has
> about 56,000 commits).

I would be _extremely_ cautious to base an argument on one particular setup, using on particular hardware with one particular OS and one particular repository.

When it comes to repositories that are worked on actively, git.git is not actually a representative example, it is way smaller than what users deal with.

You might be one of those developers privileged enough to have a fast computer. Trying to extrapolate from such a vantage point does the rest of us Git users a big disservice.

At this point, I am gently inclined against the presented approach, in particular given that even context menus reportedly trigger the re-scan (which I suspect might actually be a Linux-only issue, as context menus are top-level windows on X11, at least if I remember correctly, and I also seem to remember that they are dependent windows on Aqua and Win32, just to add yet another argument against overfitting considerations onto a single, specific setup).

Ciao, Johannes

Previous: Pratyush YadavNext: Pratyush Yadav
Message 9 of 23 in “git-gui: Perform rescan on window focus-in”
  1. git-gui: Perform rescan on window focus-inPratyush Yadav, Jul 28, 2019
  2. brian m. carlsonJul 28, 2019
  3. Pratyush YadavJul 28, 2019
  4. Pratyush YadavJul 28, 2019
  5. brian m. carlsonJul 28, 2019
  6. Mark LevedahlJul 29, 2019
  7. Mark LevedahlJul 29, 2019
  8. Pratyush YadavJul 29, 2019
  9. Johannes SchindelinJul 31, 2019
  10. Pratyush YadavAug 1, 2019
  11. Johannes SchindelinAug 2, 2019
  12. Pratyush YadavAug 2, 2019
  13. Johannes SchindelinAug 3, 2019
  14. Pratyush YadavAug 4, 2019
  15. Johannes SchindelinAug 4, 2019
  16. Pratyush YadavAug 4, 2019
  17. Junio C HamanoAug 2, 2019
  18. Pratyush YadavAug 2, 2019
  19. Johannes SchindelinAug 4, 2019
  20. Mark LevedahlJul 29, 2019
  21. Junio C HamanoJul 29, 2019
  22. Pratyush YadavJul 29, 2019
  23. Pratyush YadavJul 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.