Re: [PATCH] list-objects: don't queue root trees unless revs->tree_objects is set

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2019, 18:05 UTC
Message-ID: <xmqqftl0dqcl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190912223400.GA2580@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

>> Thanks for spotting it.  I wonder if it was broken like this forever
>> since the beginning X-<.
>
> Not quite since the beginning; it comes from 8d2dfc49b1
> (process_{tree,blob}: show objects without buffering, 2009-04-10). I
> suspect nobody noticed because the cost for the normal case is really
> just shuffling some pointers around. It's only because it actively works
> against the commit-graph optimizations that it's so expensive there.

Yeah, that is what I meant by "since the beginning" (of commit-graph, that is).

> I was surprised (and pleased) by how much such a simple thing helped.

Yes, it is very pleasing.  Thanks.