Re: [PATCH 07/13] rev-list: allow bitmaps when counting objects
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2020, 21:47 UTC
- Message-ID
- <xmqqftfeqhvp.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20200213022005.GG1126038@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> - count_bitmap_commit_list(bitmap_git, &commit_count, NULL, NULL, NULL); > + count_bitmap_commit_list(bitmap_git, &commit_count, > + revs->tree_objects ? &tree_count : NULL, > + revs->blob_objects ? &blob_count : NULL, > + revs->tag_objects ? &tag_count : NULL);
So count_bitmap_commit_list() has been prepared to count non-commits already, but we are just starting to use that feature?
Interesting.
> - printf("%d\n", commit_count);
> + printf("%d\n", commit_count + tree_count + blob_count + tag_count);Thanks.