Re: [PATCH 05/13] rev-list: factor out bitmap-optimized routines

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2020, 18:34 UTC
Message-ID: <xmqq4kvus5dm.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200213021820.GE1126038@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> There are a few operations in rev-list that are optimized for bitmaps.
> Rather than having the code inline in cmd_rev_list(), let's move them
> into helpers. This not only makes the flow of the main function simpler,
> but it lets us replace the complex "can we do the optimization?"
> conditionals with a series of early returns from the functions. That
> also makes it easy to add comments explaining those conditions.

... and these new comments makes the resulting code much easier to follow. Nicely done.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.