Re: [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 20, 2021, 21:06 UTC
- Message-ID
- <xmqqft0pk018.fsf@gitster.g>
- In-Reply-To
- <ca521d3c01d652e09e716fb447b0b26da1a014e8.1616251299.git.gitgitgadget@gmail.com>
"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 11 quoted lines
> diff --git a/commit.h b/commit.h > index 49c0f503964e..970a73ccd5be 100644 > --- a/commit.h > +++ b/commit.h > @@ -371,4 +371,6 @@ int parse_buffer_signed_by_header(const char *buffer, > struct strbuf *signature, > const struct git_hash_algo *algop); > > +const char *find_author_by_nickname(const char *name); > + > #endif /* COMMIT_H */
As I already said, we do not want to pretend that this is a generally reusable helper function. We should at least have a comment to tell people to never add new callers to this function, with explanation of the reason.