Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 22, 2021, 18:45 UTC
- Message-ID
- <xmqq5z1j6n9e.fsf@gitster.g>
- In-Reply-To
- <47e8a13f-ce96-f3f3-0f8e-efd685f58e60@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
Show 13 quoted lines
> I mean the error should be: > > ``` > error: @batman match multiple identities: > 1) batman <email1> > 2) batman <email2> > ... > n) batman <emailn> > > Please disambiguate by running "git commit --trailer" with full identity, like: > git commit --trailer="<someone> <<email>>" <options>... > > ```
Detecting error alone is probably prohibitively expensive, as it takes you to scan _all_ commits down to the beginning of time to pruve that a given pattern matches one and only one author ident.
Assuming that we would pay that cost (I doubt we would want to, though), additional cost to show all possible hits would be small and manageable, I think.