git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] pull: obvious fixes

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 15, 2021, 01:25 UTC
Message-ID
<xmqqfsxjzzpp.fsf@gitster.g>
In-Reply-To
<CABPp-BFEc2aQV_kTTiDh3WV5oBwr4tOzO6LOGnMAHudZdXVo6Q@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 5 quoted lines
> I was really surprised to see the Reviewed-by on patch 1, and did not
> remember what review I had done.  Unfortunately, ...
> from.  I had to go digging to try to find it.  Any chance you could
> tweak your posts in the future to help reviewers follow how things
> have evolved?
Sounds like a sensible request.

Aside from that, I read the three patches and think they are good. So I'll queue them as-is on 'seen' (unless they crash with something else, which is always the case without being said, but it is safer to be explicit) but won't merge it down until the above is resolved.

One way to resolve it is for you to review this round and give a refreshed Reviewed-by ;-)

Thanks, both.
Previous: Elijah NewrenNext: Felipe Contreras
Message 10 of 17 in “pull: obvious fixes”
  1. 0/3 pull: obvious fixesFelipe Contreras, Jun 13, 2021
  2. 3/3 pull: trivial whitespace style fixFelipe Contreras, Jun 13, 2021
  3. Elijah NewrenJun 14, 2021
  4. 2/3 pull: trivial cleanupFelipe Contreras, Jun 13, 2021
  5. Elijah NewrenJun 14, 2021
  6. 1/3 pull: cleanup autostash checkFelipe Contreras, Jun 13, 2021
  7. Elijah NewrenJun 14, 2021
  8. Felipe ContrerasJun 15, 2021
  9. Elijah NewrenJun 14, 2021
  10. Junio C HamanoJun 15, 2021
  11. Felipe ContrerasJun 15, 2021
  12. 0/3 pull: obvious fixesFelipe Contreras, Jun 17, 2021
  13. 1/3 pull: cleanup autostash checkFelipe Contreras, Jun 17, 2021
  14. 2/3 pull: trivial cleanupFelipe Contreras, Jun 17, 2021
  15. 3/3 pull: trivial whitespace style fixFelipe Contreras, Jun 17, 2021
  16. Elijah NewrenJun 17, 2021
  17. Felipe ContrerasJun 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.