Re: [PATCH 0/3] pull: obvious fixes

From: Elijah Newren <newren@gmail.com>
Date: Jun 14, 2021, 14:47 UTC
Message-ID: <CABPp-BFEc2aQV_kTTiDh3WV5oBwr4tOzO6LOGnMAHudZdXVo6Q@mail.gmail.com>
In-Reply-To: <20210613045949.255090-1-felipe.contreras@gmail.com>

On Sat, Jun 12, 2021 at 9:59 PM Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 7 quoted lines

>
> These are obvious fixes that I sent many times in series like [1], but
> for some reason they were never merged.
>
> There's absolutely no reason not to merge these.
>
> [1] https://lore.kernel.org/git/20201218211026.1937168-1-felipe.contreras@gmail.com/

I was really surprised to see the Reviewed-by on patch 1, and did not remember what review I had done. Unfortunately, since your new patch series aren't posted as responses to old ones (see https://lore.kernel.org/git/CABPp-BEEiPP7AEk4Wexw4_MDHcin2n8xkMowO=OXTn9pNPaG0A@mail.gmail.com/T/#u for an example of what I mean), and since the cover letter you linked to didn't reference previous series, there's no trace of where it came from. I had to go digging to try to find it. Any chance you could tweak your posts in the future to help reviewers follow how things have evolved?

Show 10 quoted lines

> Felipe Contreras (3):
>   pull: cleanup autostash check
>   pull: trivial cleanup
>   pull: trivial whitespace style fix
>
>  builtin/pull.c | 26 +++++++++++---------------
>  1 file changed, 11 insertions(+), 15 deletions(-)
>
> --
> 2.32.0