Re: [PATCH v2] Make ident dynamic, not just a hardcoded value of "$Id".

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 1, 2021, 05:35 UTC
Message-ID: <xmqqfsuosvrh.fsf@gitster.g>
In-Reply-To: <CABFYoQC_FzbU_E4hU0kCz-WFJNOLspwL2Gjc01sMXDZosxJWjw@mail.gmail.com>

Maksym Sobolyev <sobomax@gmail.com> writes:

> Junio, I've got rid of the  GIT_MAX_IDENT_LEN in rev3 posted here. You were
> right it was not really necessary.

Sounds good.

> Let me see if there are any more issues with the functional part of the
> change, if not I'll see about changing the structure name from ident_action
> to something more relevant.

I do not think the "structure" should be relevant, not just its name but its presence. As I said already, the data (i.e. the name of the custom token that replaces $Id$) should not come from the attribute subsystem---it belongs to the config subsystem, I would think.

Thanks.