Re: [PATCH v3] Make ident dynamic, not just a hardcoded value of "$Id".

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Sep 2, 2021, 03:40 UTC
Message-ID: <YTBHk+cS7WluKGL2@danh.dev>
In-Reply-To: <pull.1074.v3.git.git.1630462385587.gitgitgadget@gmail.com>

On 2021-09-01 02:13:05+0000, Maksym Sobolyev via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 12 quoted lines

> diff --git a/convert.h b/convert.h
> index 5ee1c322058..2422e289784 100644
> --- a/convert.h
> +++ b/convert.h
> @@ -76,11 +76,16 @@ enum convert_crlf_action {
>  
>  struct convert_driver;
>  
> +struct ident_action {
> +	const char *id;
> +	size_t id_len;
> +};

Just out of curiousity, can we use strbuf instead of inventing new structure for this one? This struct is purely a string representation?

-- 
Danh