Re: [PATCH 1/2] test-lib.sh: set GIT_TRACE2_EVENT_NESTING

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 29, 2021, 18:32 UTC
Message-ID: <xmqqfsre3j9j.fsf@gitster.g>
In-Reply-To: <211129.86fsrff36j.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 10 quoted lines

>  trace2.eventNesting::
> -	Integer.  Specifies desired depth of nested regions in the
> +	Integer or "false" boolean.  Specifies desired depth of nested regions in the
>  	event output.  Regions deeper than this value will be
>  	omitted.  May be overridden by the `GIT_TRACE2_EVENT_NESTING`
>  	environment variable.  Defaults to 2.
> ++
> +Set this to a "false" value (see linkgit:git-config[1] for accepted
> +values, i.e. "false", "off" etc.) to remove the limitation on nesting
> +entirely.

If the value of 5 set to .eventNesting allows up to 5 levels of nesting, I would imagine some readers expect that "false" or "off" would forbid nesting of events altogether. For "false" to work well, the variable needs renaming to trace2.limitEventNesting, or something like that.