Re: [PATCH 0/2] Set GIT_TRACE2_EVENT_NESTING in test-lib.sh

From: Jeff King <peff@peff.net>
Date: Dec 1, 2021, 19:46 UTC
Message-ID: <YafRACXUuVLs5kX4@coredump.intra.peff.net>
In-Reply-To: <8c80be3d-7151-272c-dc42-377380bf9754@jeffhostetler.com>

On Tue, Nov 30, 2021 at 05:43:28PM -0500, Jeff Hostetler wrote:

Show 8 quoted lines

> and yes, the addition of trace2 calls inside the progress code
> complicates the nesting.  I'm wondering if the progress code should
> always emit the trace2 events, regardless of whether the progress msg
> itself appears on the user's console.  That way we have consistent
> logging -- the whole point of adding the region in the progress
> code was to bracket the time spent doing the thing that needed
> progress messaging after all.  the fact that you don't have a console
> doesn't change the fact that there's an expensive computation there.

Yeah, that would at least make these things deterministic, and we'd notice a nesting problem in the tests.

I do think bumping the default nesting level a few notches may be worth it. Even if we didn't get rid of it entirely (and I am sympathetic to the notion that recursive operations could produce gigantic logs), that would give some headroom for reasonable levels of logging.

-Peff