Re: [PATCH] test-lib-functions: fix test_subcommand_inexact

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2022, 23:10 UTC
Message-ID: <xmqqfsn8p8nr.fsf@gitster.g>
In-Reply-To: <YjuVAgjaiqrcT7P1@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 15 quoted lines

> On Wed, Mar 23, 2022 at 10:55:37AM -0400, Derrick Stolee wrote:
>> > So, perhaps #3 ;-)?
>>
>> I'll default to #3 (do nothing), but if this shows up again
>> I'll plan on adding a comment to the helper to be clear on
>> how "inexact" the helper really is.
>
> I wonder if we could sidestep the whole issue with
> test_subcommand_inexact by testing this behavior by looking at the
> contents of the packs themselves.
>
> If we have a kept pack, and then add some new objects, and run "git
> repack --write-midx -adb", the new pack should not contain any of the
> objects found in the old (kept) pack. And that's the case after this
> patch, but was broken before it.

Sounds quite sensible.

Instead of saying "we are happy as long as we internally run this command, as that _should_ give us the desired outcome", we check the resulting packs ourselves, and we do not really care how the "repack" command gave us that desired outcome.