Re: [PATCH v3 0/2] test-lib-functions: fix test_subcommand_inexact

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 30, 2022, 02:44 UTC
Message-ID: <YkPECUcH3zIU4nZW@nand.local>
In-Reply-To: <pull.1185.v3.git.1648234967.gitgitgadget@gmail.com>

On Fri, Mar 25, 2022 at 07:02:45PM +0000, Derrick Stolee via GitGitGadget wrote:

Show 12 quoted lines

> Junio discovered in [1] that test_subcommand_inexact is more flexible than
> initially intended.
>
> [1] https://lore.kernel.org/git/xmqq4k41vdwe.fsf@gitster.g/
>
> The intention was that we do not need to specify the remaining arguments for
> a subcommand, but instead the current behavior is to allow the given
> arguments to appear as any subsequence within the command (except that the
> first "git" instance must be the first argument).
>
> By changing the test that needed the helper, we can avoid the helper in the
> first place. Modify the test and remove the helper.

I reviewed both patches carefully, and this version looks great to me. Thanks for all of your patience in cleaning up that sketch of the new test; you version in v3 here is delightfully easy to follow.

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor