Re: [PATCH v2] credential: clear expired c->credential, unify secret clearing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 5, 2024, 05:12 UTC
- Message-ID
- <xmqqfrtsynu7.fsf@gitster.g>
- In-Reply-To
- <87y17kbavu.fsf@nvidia.com>
Rahul Rameshbabu <rrameshbabu@nvidia.com> writes:
Show 22 quoted lines
>>> Aaron Plattner <aplattner@nvidia.com> writes: >> ... >> Rahul (CC'd) and I had a series of patches to add something similar to the >> current authtype system but hadn't gotten around to sending them to the list >> before this more flexible mechanism was merged. It's nice that this worked out >> of the box with minimal adjustment. >> >> The credential helper he wrote is specific to the Microsoft "Entra ID" identity >> provider system, but hopefully it'll be generally useful once this stuff is in a >> git release. It really cleans up the authentication process over https for sites >> that support it. > > Aaron made a commit to make it work with the authtype/credential > credential-helper infrastructure that landed in git-next. > > https://github.com/Binary-Eater/git-credential-msal/commit/f71ca9c72ca1a2cf73373de76909f6007ac689cb > > The support for authtype excites me since a number of large Git > providers like GitHub/GitLab/etc. have utilized Authorization Basic > incorrectly for supporting different authtypes with git previously. > Hoping they will move away from this practice in the future with this > enhancement.
Thanks for a huge praise that I do not personally deserve ;-) Kudos go to brian and folks who helped reviewing his topic.