Re: [PATCH v2] credential: clear expired c->credential, unify secret clearing
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> items that reject() is clearing is the best one. So I'd just as soon
> leave it as a weird internal detail for now, rather than codifying it in
> a function.
>
> I dunno. I guess it is the same lines of code in either spot, but
> somehow sticking it in a clear_response() helper seems like an
> endorsement that the author knew what they were doing. ;)
True. It probably belongs to too premature abstraction. Thanks.
Junio C Hamano <gitster@pobox.com>