Re: [PATCH v2 3/4] t-reftable-readwrite: use 'for' in place of infinite 'while' loops

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 9, 2024, 19:06 UTC
Message-ID: <xmqqfrrdcy84.fsf@gitster.g>
In-Reply-To: <20240809111312.4401-4-chandrapratap3519@gmail.com>

Chandra Pratap <chandrapratap3519@gmail.com> writes:

> Using a for loop with an empty conditional statement is more concise
> and easier to read than an infinite 'while' loop in instances
> where we need a loop variable. Hence, replace such instances of a
> 'while' loop with the equivalent 'for' loop.

Quite honestly, the above is counter-productive if pushed as a general guideline, because the goodness of it depends what happens in the third part of the for () control (i.e., what should happen at the end of each iteration and if it wants to be bypassed in the conditional inside the loop).

In this particular case, it probably is OK, but still is a subjective, borderline Meh, to me.

I see no violation of correctness in the rewrite, though ;-)