git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle: remove unneeded code

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 10, 2024, 00:15 UTC
Message-ID
<xmqqfrmwmlzh.fsf@gitster.g>
In-Reply-To
<CAOLa=ZQpBf-ZE8BmXRUXJ247p44Enj0vrJv2KHVDXtGzY6SU8w@mail.gmail.com>
karthik nayak <karthik.188@gmail.com> writes:
Show 10 quoted lines
>> The workaround was originally added to deal with tags, but the code path
>> also gets hit by non-tag refs, causing this race condition. Because it's
>> no longer needed, remove it and fix the possible race condition.
>
> Nice, simple fix.
>
> [snip]
> ...
> Shouldn't we add a test for an annotated tag and verify that the tag
> object is also included in the bundle?

I agree that it is a good idea, especially because 895c5ba3c1 (revision: do not peel tags used in range notation, 2013-09-19) naturally does not come with a test for "git bundle".

Thanks.
Previous: karthik nayakNext: Junio C Hamano
Message 3 of 4 in “bundle: remove unneeded code”
  1. bundle: remove unneeded codeToon Claes, Dec 9, 2024
  2. karthik nayakDec 9, 2024
  3. Junio C HamanoDec 10, 2024
  4. Junio C HamanoDec 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.