From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Dec 2024 00:15:46 GMT
Subject: Re: [PATCH] bundle: remove unneeded code
Message-ID: <xmqqfrmwmlzh.fsf@gitster.g>
In-Reply-To: <CAOLa=ZQpBf-ZE8BmXRUXJ247p44Enj0vrJv2KHVDXtGzY6SU8w@mail.gmail.com>

karthik nayak <karthik.188@gmail.com> writes:

>> The workaround was originally added to deal with tags, but the code path
>> also gets hit by non-tag refs, causing this race condition. Because it's
>> no longer needed, remove it and fix the possible race condition.
>
> Nice, simple fix.
>
> [snip]
> ...
> Shouldn't we add a test for an annotated tag and verify that the tag
> object is also included in the bundle?

I agree that it is a good idea, especially because 895c5ba3c1
(revision: do not peel tags used in range notation, 2013-09-19)
naturally does not come with a test for "git bundle".

Thanks.