Re: [PATCH] compat: fixes for header handling with OpenBSD / NetBSD

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2025, 00:36 UTC
Message-ID: <xmqqfrghslu0.fsf@gitster.g>
In-Reply-To: <87wm9ut3uo.fsf@gmail.com>

Collin Funk <collin.funk1@gmail.com> writes:

Show 7 quoted lines

> Just one question about this chunk:
>
>>  #define _DEFAULT_SOURCE 1
>> -#define _NETBSD_SOURCE 1
>
> Why remove this definition? I think it might be useful on some older
> systems and seems harmless otherwise.

Yes, it is curious.

Show 7 quoted lines

>
> Other than that, I tested on OpenBSD 7.6 and NetBSD 10.0 and this patch
> fixes the missing declarations. So:
>
> Reviewed-by: Collin Funk <collin.funk1@gmail.com>
>
> Collin