Re: [PATCH] compat: fixes for header handling with OpenBSD / NetBSD

From: Brad Smith <brad@comstyle.com>
Date: Jun 3, 2025, 03:56 UTC
Message-ID: <47c58a78-d38b-4170-87fc-c9332618d0da@comstyle.com>
In-Reply-To: <87wm9ut3uo.fsf@gmail.com>

On 2025-06-02 2:06 p.m., Collin Funk wrote:

Show 26 quoted lines

> Hi Brad,
>
> You wrote:
>
>> Handle OpenBSD and NetBSD as FreeBSD / DragonFly are. OpenBSD would
>> need _XOPEN_SOURCE to be set to 700. Its simpler to just not set
>> _XOPEN_SOURCE.
>>
>>      CC strbuf.o
>> strbuf.c:645:6: warning: call to undeclared function 'getdelim'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>>          r = getdelim(&sb->buf, &sb->alloc, term, fp);
>>              ^
>> 1 warning generated.
>>
>> Signed-off-by: Brad Smith <brad@comstyle.com>
>> ---
>>   compat/posix.h | 11 +++++------
>>   1 file changed, 5 insertions(+), 6 deletions(-)
> I noticed this as well when testing your other fixes.
>
> Just one question about this chunk:
>
>>   #define _DEFAULT_SOURCE 1
>> -#define _NETBSD_SOURCE 1
> Why remove this definition? I think it might be useful on some older
> systems and seems harmless otherwise.

_XOPEN_SOURCE restricts the build environment. _NETBSD_SOURCE is added to counteract _XOPEN_SOURCE. Not setting it in the first place provides everything by default.

I was removing it as it should no longer be necessary.

But as said, it is harmless. I can leave it in if desired.

Show 7 quoted lines

> Other than that, I tested on OpenBSD 7.6 and NetBSD 10.0 and this patch
> fixes the missing declarations. So:
>
> Reviewed-by: Collin Funk <collin.funk1@gmail.com>
>
> Collin
>