Re: [PATCH v2 2/2] format-patch: add commitListFormat config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2026, 17:25 UTC
- Message-ID
- <xmqqfr6oburb.fsf@gitster.g>
- In-Reply-To
- <aZ46xqCusF1av-va@exploit>
Mirko Faina <mroik@delayed.space> writes:
Show 5 quoted lines
>> > + if (cover_letter_fmt && (strcmp(cover_letter_fmt, "shortlog") && strncmp(cover_letter_fmt, "log:", 4))) {
>>
>> Overly long line.
>
> Will fix.A minor thing, but using starts_with(cover_letter_fmt, "log:") would let us without having to count the number of bytes in the "log:" prefix (and we do not have to keep recounting every time we decide to change the prefix used---which is not likely to happen in this particular case).
Thanks.