From: Junio C Hamano Date: Wed, 25 Feb 2026 17:25:28 GMT Subject: Re: [PATCH v2 2/2] format-patch: add commitListFormat config Message-ID: In-Reply-To: Mirko Faina writes: >> > + if (cover_letter_fmt && (strcmp(cover_letter_fmt, "shortlog") && strncmp(cover_letter_fmt, "log:", 4))) { >> >> Overly long line. > > Will fix. A minor thing, but using starts_with(cover_letter_fmt, "log:") would let us without having to count the number of bytes in the "log:" prefix (and we do not have to keep recounting every time we decide to change the prefix used---which is not likely to happen in this particular case). Thanks.