git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ls-files: filter pathspec before lstat

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 11, 2026, 17:38 UTC
Message-ID
<xmqqfr2tnfk0.fsf@gitster.g>
In-Reply-To
<20260611084132.GK2191159@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
>> Yeah, absolutely it's arbitrary. The simplest answer is that others
>> are welcome to bump this, provided they make the case for it.
>
> OK. I can live with, I suppose, but I am tempted to say that it should
> just kick in always (i.e., removing the pathspec.nr check).
Yeah, that is certainly simpler, and this ...
> Though I did show a case where the performance regresses, it was pretty
> made-up and not something I'd expect in the real world. And you'd see
> that same crappy performance with "git ls-files -- $(git ls-files)",
> without the "-m".

... makes it clear that "trigger only when there is one element in the pathspec" is optimizing for a wrong case.

I think we want the log message document that this kind of thinking went into the final choice of the heuristics, like, "trigger only when there is one because ...", or "even though it would actually be an anti-optimization when the pathspec has enourmous number of elements, we always use this optimization because ...", but as long as that is done, either solution is fine.

Thanks.
Previous: Tamir DubersteinNext: Tamir Duberstein
Message 10 of 12 in “ls-files: filter pathspec before lstat”
  1. ls-files: filter pathspec before lstatTamir Duberstein, Jun 9, 2026
  2. Junio C HamanoJun 9, 2026
  3. Tamir DubersteinJun 9, 2026
  4. Junio C HamanoJun 9, 2026
  5. Tamir DubersteinJun 9, 2026
  6. Jeff KingJun 9, 2026
  7. Tamir DubersteinJun 9, 2026
  8. Jeff KingJun 11, 2026
  9. Tamir DubersteinJun 11, 2026
  10. Junio C HamanoJun 11, 2026
  11. ls-files: filter pathspec before lstatTamir Duberstein, Jun 12, 2026
  12. Junio C HamanoJun 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.