Re: [PATCH v2] ls-files: filter pathspec before lstat
- From
Tamir Duberstein <tamird@gmail.com>
- Date
- Jun 9, 2026, 03:38 UTC
- Message-ID
- <CAJ-ks9ku-uYeZ+3BhLAzrNdnOc7qnhudxQgy6PwU93jmr7ka+w@mail.gmail.com>
- In-Reply-To
- <xmqqv7bstmw8.fsf@gitster.g>
On Mon, Jun 8, 2026 at 8:26 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> > Tamir Duberstein <tamird@gmail.com> writes: > > > show_files() checks whether each index entry is deleted or modified > > before show_ce() applies the pathspec. prune_index() avoids most of this > > work for pathspecs with a common directory prefix, but a top-level name > > or leading wildcard leaves every entry to be checked. > > ... > > Please make sure that your v2 is a response to v1; otherwise loses > sight of the previous iteration. > > > Changes in v2: > > - Restrict early matching to one pathspec, avoiding the regression Jeff > > demonstrated with many pathspecs. > > - Add all-matching and many-pathspec performance results. > > - Drop the Assisted-by trailer. > > - Link to v1: https://patch.msgid.link/20260607-ls-files-pathspec-lstat-v1-1-8cf40b730146@gmail.com > > And it is *not* a replacement to force human to follow such a link. > > Instead, please make sure each piece of your e-mail identifies where > it fits in the discussion thread by pointing the message of the > previous round with its In-Reply-To: header. > > Thanks.
Apologies, I used b4 which follows kernel rules. I'll follow this guidance in the future.