Re: [PATCH 00/20] t9300: group and move tests to other files
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2026, 20:06 UTC
- Message-ID
- <xmqqfqx8qwmv.fsf@gitster.g>
- In-Reply-To
- <xmqqik24tz2x.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes: > >> While reading the git-fast-import(1) code, I stumbled upon t9300. The >> test file is around 4000 LoC and each test has some dependency on the >> state setup by previous tests. >> >> This long series unwinds some of these tests and moves them into >> new/existing tests based on what they exercise. This leaves t9300 in a >> better state. I think we can do more here, but I decided to stop before >> this series got even longer. Based on the reception of this series, I >> will follow up with more cleanups. > > Wow, cleaning up this script is long overdue. Thanks for tackling it.
Having said that, there are a few topics in flight that touch this age-old script and they are already in 'next'.
(cc/early-scan-options) c2b4099f84 fast-import: use early_scan_options() for --allow-unsafe-features cc4affc5ee parse-options: add early_scan_options() f7fd8656e9 parse-options: extract lookup_long_opt() from parse_long_opt() 6aa1fb2271 parse-options: add parse_options_takes_argument()
(tj/drop-no-parseopt) 1db50e0e62 t0012: catch builtins that keep NO_PARSEOPT after conversion 5d735e50ef git.c: drop NO_PARSEOPT from builtins that use parse-options ee68c316a7 parse-options: answer --git-completion-helper before command runs
So you may want to rebase this clean-up on a synthetic base, starting at 1891de46f7 (Sync with Git 2.56.1, 2026-11-09) and merging these two topics on top.
Thanks.