git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/20] t9300: group and move tests to other files

From
Karthik Nayak <karthik.188@gmail.com>
Date
Nov 10, 2026, 11:49 UTC
Message-ID
<20261110-kn-fast-import-tests-1-v1-0-dbd9ee502aae@gmail.com>

While reading the git-fast-import(1) code, I stumbled upon t9300. The test file is around 4000 LoC and each test has some dependency on the state setup by previous tests.

This long series unwinds some of these tests and moves them into new/existing tests based on what they exercise. This leaves t9300 in a better state. I think we can do more here, but I decided to stop before this series got even longer. Based on the reception of this series, I will follow up with more cleanups.

Also, we could squash some of the commits together. But I found them easier to read through this way.

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
Karthik Nayak (20):
      t9300: move 'fastimport.unpackLimit' to the required test
      t9300: make the series B tests self-contained
      t9300: make the series T tests self-contained
      t9300: make the series S tests self-contained
      t9300: make the series V tests self-contained
      t9300: make the series Q tests self-contained
      t9300: make the series P tests self-contained
      t9300: make the series O tests self-contained
      t9300: make the big blob tests self-contained
      t9300: make the ref update tests self-contained
      t9300: make the date format tests self-contained
      t9300: make the pack edges test self-contained
      t9300: make the marks tests self-contained
      t9300: make the series Y tests self-contained
      t9300: make the cat-blob tests self-contained
      t9300: make the feature and option tests self-contained
      t9300: make the stream tests self-contained
      t9300: make the get-mark and encoding tests self-contained
      t9300: move self-contained tests into dedicated files
      t93xx: drop the series letter from the moved test names
 t/meson.build                     |    5 +
 t/t9300-fast-import.sh            | 2780 +------------------------------------
 t/t9301-fast-import-notes.sh      |  411 ++++++
 t/t9304-fast-import-marks.sh      |  393 ++++++
 t/t9307-fast-import-validation.sh | 1193 ++++++++++++++++
 t/t9308-fast-import-stream.sh     |  822 +++++++++++
 t/t9309-fast-import-checkpoint.sh |  188 +++
 t/t9310-fast-import-submodule.sh  |  341 +++++
 t/t9311-fast-import-refs.sh       |  194 +++
 9 files changed, 3548 insertions(+), 2779 deletions(-)

--- base-commit: 8d1b215c01512b9658d4525c54ff9b9245f9a7e8 change-id: 20261102-kn-fast-import-tests-1-03de57101c3b

Thanks
- Karthik
Next: Karthik Nayak
Message 1 of 45 in “t9300: group and move tests to other files”
  1. 00/20 t9300: group and move tests to other filesKarthik Nayak, Nov 10, 2026
  2. 01/20 t9300: move 'fastimport.unpackLimit' to the required testKarthik Nayak, Nov 10, 2026
  3. 02/20 t9300: make the series B tests self-containedKarthik Nayak, Nov 10, 2026
  4. 03/20 t9300: make the series T tests self-containedKarthik Nayak, Nov 10, 2026
  5. 04/20 t9300: make the series S tests self-containedKarthik Nayak, Nov 10, 2026
  6. 05/20 t9300: make the series V tests self-containedKarthik Nayak, Nov 10, 2026
  7. 06/20 t9300: make the series Q tests self-containedKarthik Nayak, Nov 10, 2026
  8. 07/20 t9300: make the series P tests self-containedKarthik Nayak, Nov 10, 2026
  9. 08/20 t9300: make the series O tests self-containedKarthik Nayak, Nov 10, 2026
  10. 09/20 t9300: make the big blob tests self-containedKarthik Nayak, Nov 10, 2026
  11. 10/20 t9300: make the ref update tests self-containedKarthik Nayak, Nov 10, 2026
  12. 11/20 t9300: make the date format tests self-containedKarthik Nayak, Nov 10, 2026
  13. 12/20 t9300: make the pack edges test self-containedKarthik Nayak, Nov 10, 2026
  14. 13/20 t9300: make the marks tests self-containedKarthik Nayak, Nov 10, 2026
  15. 14/20 t9300: make the series Y tests self-containedKarthik Nayak, Nov 10, 2026
  16. 15/20 t9300: make the cat-blob tests self-containedKarthik Nayak, Nov 10, 2026
  17. 16/20 t9300: make the feature and option tests self-containedKarthik Nayak, Nov 10, 2026
  18. 17/20 t9300: make the stream tests self-containedKarthik Nayak, Nov 10, 2026
  19. 18/20 t9300: make the get-mark and encoding tests self-containedKarthik Nayak, Nov 10, 2026
  20. 19/20 t9300: move self-contained tests into dedicated filesKarthik Nayak, Nov 10, 2026
  21. 20/20 t93xx: drop the series letter from the moved test namesKarthik Nayak, Nov 10, 2026
  22. Junio C HamanoNov 10, 2026
  23. Junio C HamanoNov 10, 2026
  24. Karthik NayakNov 11, 2026
  25. 00/20 t9300: group and move tests to other filesKarthik Nayak, Nov 12, 2026
  26. 01/20 t9300: move 'fastimport.unpackLimit' to the required testKarthik Nayak, Nov 12, 2026
  27. 02/20 t9300: make the series B tests self-containedKarthik Nayak, Nov 12, 2026
  28. 03/20 t9300: make the series T tests self-containedKarthik Nayak, Nov 12, 2026
  29. 04/20 t9300: make the series S tests self-containedKarthik Nayak, Nov 12, 2026
  30. 05/20 t9300: make the series V tests self-containedKarthik Nayak, Nov 12, 2026
  31. 06/20 t9300: make the series Q tests self-containedKarthik Nayak, Nov 12, 2026
  32. 07/20 t9300: make the series P tests self-containedKarthik Nayak, Nov 12, 2026
  33. 08/20 t9300: make the series O tests self-containedKarthik Nayak, Nov 12, 2026
  34. 09/20 t9300: make the big blob tests self-containedKarthik Nayak, Nov 12, 2026
  35. 10/20 t9300: make the ref update tests self-containedKarthik Nayak, Nov 12, 2026
  36. 11/20 t9300: make the date format tests self-containedKarthik Nayak, Nov 12, 2026
  37. 12/20 t9300: make the pack edges test self-containedKarthik Nayak, Nov 12, 2026
  38. 13/20 t9300: make the marks tests self-containedKarthik Nayak, Nov 12, 2026
  39. 14/20 t9300: make the series Y tests self-containedKarthik Nayak, Nov 12, 2026
  40. 15/20 t9300: make the cat-blob tests self-containedKarthik Nayak, Nov 12, 2026
  41. 16/20 t9300: make the feature and option tests self-containedKarthik Nayak, Nov 12, 2026
  42. 17/20 t9300: make the stream tests self-containedKarthik Nayak, Nov 12, 2026
  43. 18/20 t9300: make the get-mark and encoding tests self-containedKarthik Nayak, Nov 12, 2026
  44. 19/20 t9300: move self-contained tests into dedicated filesKarthik Nayak, Nov 12, 2026
  45. 20/20 t93xx: drop the series letter from the moved test namesKarthik Nayak, Nov 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.