Re: [PATCH 3/7] abspath: trivial style fix

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2013, 21:24 UTC
Message-ID: <xmqqeh5lwwej.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1386482220-18558-4-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 15 quoted lines

> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  abspath.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/abspath.c b/abspath.c
> index e390994..8b3385a 100644
> --- a/abspath.c
> +++ b/abspath.c
> @@ -143,7 +143,7 @@ static const char *real_path_internal(const char *path, int die_on_error)
>  error_out:
>  	free(last_elem);
>  	if (*cwd && chdir(cwd))
> -		die_errno ("Could not change back to '%s'", cwd);
> +		die_errno("Could not change back to '%s'", cwd);

Will queue; thanks.

By the way, there are quite a few hits from

	git grep -e '\(die\|error\|warning\) (' -- \*.c

even if we ignore borrowed code that we do not want to touch up with this kind of change. Some may have overlapping changes in flight that makes it better to leave them as they are for now, but some are in reasonably quiescent areas.