Re: [PATCH 5/7] fetch: add missing documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2013, 21:26 UTC
Message-ID: <xmqqa9g9wwa7.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1386482220-18558-6-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 19 quoted lines

> There's no mention of the 'origin' default, or the fact that the
> upstream tracking branch remote is used.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  Documentation/git-fetch.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/git-fetch.txt b/Documentation/git-fetch.txt
> index e08a028..a7b245d 100644
> --- a/Documentation/git-fetch.txt
> +++ b/Documentation/git-fetch.txt
> @@ -37,6 +37,9 @@ or from several repositories at once if <group> is given and
>  there is a remotes.<group> entry in the configuration file.
>  (See linkgit:git-config[1]).
>  
> +When no remote is specified, by default the `origin` remote will be used,
> +unless there's an upstream branch configured for the current branch.
> +

It is better than saying nothing, but the reader will be left wondering what happens when "upstream branch" is configured with the above text.

    When no remote is specified, by default the `origin` remote will
    be used, unless there's an upstream branch configured for the
    current branch, in which case the `fetch` goes to the remote the
    specified upstream remote-tracking branch is taken from.

or something, perhaps?

>  OPTIONS
>  -------
>  include::fetch-options.txt[]