Re: [RFH] renaming strcmp/strncmp-icase
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 8, 2014, 19:56 UTC
- Message-ID
- <xmqqegvlnay6.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <540E03F6.3010100@web.de>
Torsten Bögershausen <tboegi@web.de> writes:
> And then we have this in name-hash.c: > (Which may explain the "icase" suffix ?) > > static int same_name(const struct cache_entry *ce, const char *name, int namelen, int icase)
As this file-scope static function takes the "icase" as an explicit argument, I do not see anything confusing about it. My complaint was it is confusing that str[n]cmp_icase is not always icase, even though the name of the function implies that it would be to those who haven't looked at its implementation for a while.