Re: [PATCH v6 1/1] http: Add Accept-Language header if possible

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 29, 2014, 16:18 UTC
Message-ID: <xmqqegri1lbs.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cQZG3gWEw8_HHHvP6EDLKkf-nMZLwkE4OF9hwNX72wgXw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Just a few comments and observations below. Alone, they are not
> necessarily worth a re-roll, but if you happen to re-roll for some
> other reason, perhaps take them into consideration.

I actually think everything you said in this review makes sense and will make the resulting code a lot better (especially the part on the parsing loop).

Thanks, as usual, for a careful reading.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.